Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the logic for repetable strings. #508

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Conversation

KevinJump
Copy link
Owner

Fixes logic for when a repeatable string is
"inside a nested content item - inside a nested content item - inside a doctype grid editor - inside a Grid."

  • this does change how we seariaze nested content slightly (it returns the JToken to the upper level not an object of string).

Testing required before merge!!!

I think we returned a string here because a) it worked and b) it might have had a knock on effect to Block List or Contentment Blocks. - so before release we will need to confirm they don't get effected , although i think they now have override methods in place so don't use this base method for the final extraction of their string.

@KevinJump KevinJump marked this pull request as ready for review July 19, 2023 09:48
@KevinJump KevinJump merged commit b1ad552 into v10/dev Jul 19, 2023
@KevinJump KevinJump deleted the v10/repeatables branch July 19, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant