Fix Structure items order by Alias - broken when Export On Save #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinJump
approved these changes
Sep 23, 2019
|
The effect of this is that the serialized output in one case and the other is quite different, producing multiple (fake) differences in the source control repo. |
|
yeah, it looks fine :) - just seeing if I can fix the automated checks (Azure DevOps permissions :( ) |
|
Sure. I will delete my fork now. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a full export is manually triggered, the
<Structure>children are ordered by Alias as designed.But when an Export on Save is triggered, the same code fails to sort the items.
The reason for that is that in this line:
...the x.Alias property is null when called from Export On Save.