Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Child files created even when there are no changes #623

Closed
NikRimington opened this issue Apr 17, 2024 · 1 comment
Closed

[BUG] Child files created even when there are no changes #623

NikRimington opened this issue Apr 17, 2024 · 1 comment

Comments

@NikRimington
Copy link
Contributor

Describe the bug
Doing a full export on a "child" site with roots unlocked creates a large number of files for document types that still match the root definition. I don't think it should create these files.

To Reproduce

  1. Create a v13 site with a root set of uSync files and a child set of usync files
  2. Ensure that the document types/data types match the expected final outcome and that some document types/data types differ from the root definition but not all
  3. Goto the uSync dashboard
  4. Run an Export on Settings
  5. Review the files generated

Expected behavior
The Child directory should only contain files where the defintion needs to differ from the root.

Screenshots
All the files with an A indicator (examples circled in green) are basically placeholder files
Files with an M indicator are legitimate changes.
image

Example of placeholder file:
image

Additional context
Not a major bug in practical terms, but is a large number of files in large sites it creates alot of file noise.

@KevinJump
Copy link
Owner

thanks,

yes - i think on the things where we merge the properties there can (and does by the looks of it) end up with a empty 'stub' when its merged,

we should just not save these if they have no children in the node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants