uSync reports shows Angular template

[deMD]

Describe the bug
When running uSync on Umbraco 8 when looking at the report it shows only angular templates instead of data. This happens on an Umbraco 8 website which had been upgraded from 8.0.0 to 8.1.0. Reinstalling uSync has not resolved the issue.

Umbraco 8.1.0
uSync 8.1.0

[KevinJump]

Hi

have you tried updating the ClientDependency Version in the config/clientdependency.config file ? it might be some cached javascript between upgrades.

Kevin

[deMD]

Not tried that yet, will do.

[deMD]

Changing the ClientDependency version did not change the issue sadly.

[ThomasSkyldahl]

Hi Kevin, I stumpled upon the same issue, its caused by changes to the default JSON Serializer, seems like uSync uses the default serializer settings, it would' probably be good to use special JsonSerializerSettings when serializing and Deserializing in uSync to ensure the formatting is correct.

[KevinJump]

yeah, I suspected so - we do force a few places, we must have missed a few

https://github.com/KevinJump/uSync8/blob/v8/8.2/uSync8.BackOffice/Models/SyncProgressModels.cs#L9

[deMD]

Ah that makes sense. I always remove the existing settings and add my own settings to make sure it formats according to our wishes.

For reference here are my settings:

GlobalConfiguration.Configuration.Formatters.Add(new JsonMediaTypeFormatter
                {
                    SerializerSettings = new JsonSerializerSettings
                    {
                        ContractResolver = new CamelCasePropertyNamesContractResolver(),
                        ReferenceLoopHandling = ReferenceLoopHandling.Ignore,
                        Formatting = Formatting.Indented
                    }
                }); 

[ThomasSkyldahl]

On this one:
https://github.com/KevinJump/uSync8/blob/2bd2aa544dcfc9314384458d76ff21702d2739d3/uSync8.BackOffice/Models/SyncAction.cs#L13

[ThomasSkyldahl]

Enums should also be decorated as some prefer them as strings by default others as integers.

[KevinJump]

you have to be careful doing that, as there have been places in the Umbraco Core where the setting has been missed and then that stops to.

[KevinJump]

it's safer to do it per controller (can't remember exactly but you can mark up formatters by the controller and then you don't risk breaking other things).

but yes we will fix all our classes to ensure they stay as expected for us.

[ThomasSkyldahl]

thats a good point, we already have our specialized serializer settings registered in the DI as we use them for other stuff than web requests, so its nice to be able to inject our SharedSerializerSettings.

[KevinJump]

this will be in the next release 8.2.1