Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export (v8) does not remove existing files/folder #26

Closed
JoseMarcenaro opened this issue May 29, 2019 · 3 comments
Closed

Export (v8) does not remove existing files/folder #26

JoseMarcenaro opened this issue May 29, 2019 · 3 comments
Assignees

Comments

@JoseMarcenaro
Copy link
Contributor

Hi.
When exporting configs, the existing folders and files are not removed. I'm using Umbraco v8.0.2 and uSync release version (8.0.0)

Steps to reproduce: files not removed

  1. Export
  2. Delete a document type
  3. Export again
    The deleted document type remains on disk

Steps to reproduce: folders not removed

  1. Create a folder in Document Types and create a Document Type inside
  2. Export
  3. Rename the folder
  4. Export again
    The new folder is serialized and the old one stays on disk, - the doc.type definition is duplicated.
    Running the Report action shows the definition needs to be Updated..
@KevinJump
Copy link
Owner

Hi

uSync8 will not completely remove the files when a delete happens, instead, it creates an 'empty' file which allows us to mark the item as deleted or renamed, this has a number of advantages over the 'action file' method of v7 - firstly it lets deletes happen inline with other actions, and its good for people deploying usync as they don't have to have scripts cleaning folders before deployment.

i will check the folder one, it should do the same thing (this time marking the empty file as a 'rename') but will double check that works.
and you might get a update message because of this, we need to check that

@JoseMarcenaro
Copy link
Contributor Author

Oh, I didn't realize it was a marker file. Thanks for explaining, it sounds like a great solution for the deletions.

Regarding renaming a folder, it is an edge case.. but it might happen so let me know if you find a fix.
Thanks!!

@KevinJump
Copy link
Owner

just cleaning up - this was released v8.0.1 (so a while ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants