Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error is reported if a datatype is missing #143

Closed
Myster opened this issue Jul 16, 2020 · 2 comments
Closed

No error is reported if a datatype is missing #143

Myster opened this issue Jul 16, 2020 · 2 comments
Labels
bug Something isn't working release/8.6.4 8.6.4 - Patch release.

Comments

@Myster
Copy link

Myster commented Jul 16, 2020

Given a DataType synchronised by a file called ControlsTest.config
When I deployed the website I had a bug in my cleanup that deleted *test.config files.
When the import ran it failed to add the datatype (no way uSyunc would know something went wrong)
When the import ran it ALSO failed to import properties using that datatype. (uSync should have known)
Then I expected there should be an error for the properties that failed to import.
However I got no indication it failed, except when I ran it again it still had the same properties to import.

  • Umbraco Version: 8.6.3
  • uSync Version:8.6.3
  • OS: Microsoft Windows Server 2016 Standard
  • Browser: Chrome
KevinJump pushed a commit that referenced this issue Jul 16, 2020
@KevinJump KevinJump added the release/8.6.4 8.6.4 - Patch release. label Jul 16, 2020
@KevinJump
Copy link
Owner

there is two parts to this, the easy part is reporting when the content item doesn't have the resultant property (done in 0f6aae2)

The slightly more complex part is reporting when the datatype definition can't be found during the content type creation, so that part will likey not make the 8.6.4 release.

@KevinJump KevinJump added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Jul 16, 2020
@KevinJump
Copy link
Owner

Closing this one, as the patch now handles the first issue - created new issue for next release to be better at the rest of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release/8.6.4 8.6.4 - Patch release.
Projects
None yet
Development

No branches or pull requests

2 participants