Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple DataTypes not saved if names of those started from a distinguish number, but the rest names are the same #133

Closed
ReVoid opened this issue Jul 13, 2020 · 2 comments
Assignees
Labels
Compatability 3rd party pluging / package compatability update. release/8.6.4 8.6.4 - Patch release.

Comments

@ReVoid
Copy link

ReVoid commented Jul 13, 2020

If multiple datatypes of the same type with a name started from a number, the only one be created by uSync

How to reproduce:

  1. Create several DataType of the same type.
    Textarea in my case
  2. Name it like "1 some name", "2 some name" etc.
    Example in my case:
    image
  3. Check what uSync saves.
    Example in my case:
    image
    (it is all that has been saved, nothing else)

Environment

Umbraco 8.6.1
uSync 8.6.1

@KevinJump KevinJump transferred this issue from KevinJump/uSync-Legacy Jul 13, 2020
@KevinJump
Copy link
Owner

yeah ☹️ looks like we use the internal Umbraco ToSafeFileName function which strips leading numbers - we do however have a function to handle file clashes, but we currently only use it on tree based items (like content) where the internal names can actually clash.
https://github.com/KevinJump/uSync8/blob/v8/dev/uSync8.ContentEdition/Handlers/ContentHandlerBase.cs#L58)

think we can safely move this up the bases classes so it's implemented on all items. (need to test that)

@KevinJump KevinJump added the release/8.6.4 8.6.4 - Patch release. label Jul 13, 2020
@KevinJump KevinJump self-assigned this Jul 13, 2020
KevinJump added a commit that referenced this issue Jul 13, 2020
@KevinJump
Copy link
Owner

fixed for the next release,

workaround till then would be to use UseGuidFileNames setting (see docs) (this would require a clean export so the other files are removed)

@KevinJump KevinJump added bug Something isn't working Compatability 3rd party pluging / package compatability update. and removed bug Something isn't working labels Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compatability 3rd party pluging / package compatability update. release/8.6.4 8.6.4 - Patch release.
Projects
None yet
Development

No branches or pull requests

2 participants