Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR #4383 with various fixes #3

Conversation

BenHenning
Copy link

@BenHenning BenHenning commented Sep 22, 2022

Explanation

This issue is aiding in the investigation and fixing of oppia#4383.

The main issue I ran into was a build failure that seems to have come up from syncing with the latest develop changes.

I ran all of the Mark*CompletedTest suites 20 times each and did not see any flaky results (every run passed as expected).

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

N/A -- This just fixes a build error & doesn't change existing UIs or tests.

@BenHenning BenHenning mentioned this pull request Sep 22, 2022
6 tasks
@BenHenning BenHenning changed the title Update PR #4383 with various fixes Update PR #4383 with various fixes [Blocked on #4] Sep 22, 2022
@BenHenning BenHenning marked this pull request as ready for review September 29, 2022 08:56
@BenHenning
Copy link
Author

@KevinGitonga PTAL.

@BenHenning BenHenning changed the title Update PR #4383 with various fixes [Blocked on #4] Update PR #4383 with various fixes Sep 29, 2022
@KevinGitonga KevinGitonga merged commit 60b6e25 into KevinGitonga:fix-all-checkbox-uncheck-issue Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants