Make: generate dependency files #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestingBEFOREAFTER |
wipawel
reviewed
Aug 30, 2020
Makefile
Outdated
| @@ -89,9 +89,14 @@ $(TARGET): $(OBJS) | |||
| @echo "AS " $@ | |||
| @ $(CC) -c -o $@ $(AFLAGS) $< | |||
|
|
|||
| DEPFLAGS := -MMD | |||
There was a problem hiding this comment.
The flag is already part of COMMON_FLAGS.
There was a problem hiding this comment.
Fun. Then we only need the rule to actually include those dep files.
Makefile
Outdated
| %.o: %.c | ||
| @echo "CC " $@ | ||
| @ $(CC) -c -o $@ $(CFLAGS) $< | ||
| @$(CC) -c -o $@ $(CFLAGS) $(DEPFLAGS) $< |
There was a problem hiding this comment.
Not needed, -MMD should be there
|
While we are at it, can we also store all *.d in a dedicated dir like: .deps ? Is the dependency for a linker script also covered? |
Let's leave that for later.
I pulled the PREP_LINK_SCRIPT generation into a separate rule. |
wipawel
previously approved these changes
Aug 30, 2020
Makefile
Outdated
|
|
||
| %.o: %.S | ||
| @echo "AS " $@ | ||
| @ $(CC) -c -o $@ $(AFLAGS) $< | ||
|
|
||
| %.o: %.c | ||
| @echo "CC " $@ | ||
| @ $(CC) -c -o $@ $(CFLAGS) $< | ||
| @$(CC) -c -o $@ $(CFLAGS) $< |
Generate dependency files for our C files so that we actually rebuild them when local header files are modified. Signed-off-by: Bjoern Doebel <[email protected]>
Signed-off-by: Bjoern Doebel <[email protected]>
wipawel
approved these changes
Aug 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate dependency files for our C files so that we actually rebuild them when
local header files are modified.
Signed-off-by: Bjoern Doebel [email protected]
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.