Docker build #81
Merged
Docker build #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fedora uses some stringent SELinux configuration that fails to pass through shared directories to a container. To fix this, we need to ask Docker to properly adjust the directory's permissions before passing it through. http://www.projectatomic.io/blog/2015/06/using-volumes-with-docker-can-cause-problems-with-selinux/ Add a config variable to our docker run command and extend the Fedora example in the README. Signed-off-by: Bjoern Doebel <[email protected]>
|
This breaks MAC builds again... :( |
Docker by default executes things as the root user, leading to permissions problems further down the road. (i.e., if I build boot.iso in docker, the resulting file is owned by root and a later `make boot` fails on my Linux system.) Fix this by creating a user within our docker image that has the appropriate user ID and group ID of the outside user. Thus, resulting files have proper ownership and make boot succeeds. Signed-off-by: Bjoern Doebel <[email protected]>
Depending on the `all` target, caused a chain of `make boot` -> `make boot.iso` to always execute. However, we only want to regenerate the ISO if the kernel.bin has changed. Hence, make the ISO_FILE target explicitly depend on the kernel.bin file instead. Signed-off-by: Bjoern Doebel <[email protected]>
wipawel
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adjust the way we build our docker image so that later builds run with the user and group ID of the outside user rather than root and thereby prevent file permission issues with the resulting builds.
Fixes #53
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.