Reserve multiboot physical memory #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just realized there might be an issue when there is no multiboot image since the range would then be the empty range at 0 and block the first physical memory page. |
wipawel
reviewed
Dec 2, 2024
sparchatus
force-pushed
the
reserve_multiboot
branch
from
564bec9 to
0f4a50c
Compare
wipawel
reviewed
Dec 3, 2024
|
In the future, we probably should add another flag reserved to the frame_t and handle it properly in the PMM. Then, maybe instead of skipping the frames, we could create them and reserve (consume) them immediately. Same should apply to all the memory regions reported as reserved by multiboot, ACPI and others. |
sparchatus
force-pushed
the
reserve_multiboot
branch
2 times, most recently
from
1363707 to
b9deb8f
Compare
wipawel
reviewed
Dec 4, 2024
sparchatus
force-pushed
the
reserve_multiboot
branch
from
b9deb8f to
6b2382d
Compare
Add a reserved regions feature to regions.c. Reserved memory regions are prohibited from being used as frames by pmm. Currently, the only reserved region is the multiboot memory. Signed-off-by: Sandro Rüegge <[email protected]>
sparchatus
force-pushed
the
reserve_multiboot
branch
from
6b2382d to
dd5b1d3
Compare
wipawel
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #342 by passing the multiboot memory range to the physical memory manager. The physical memory manager then skips any memory overlapping with the multiboot memory range.