Unittest That Stress-Tests the VMM and PMM #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcjgraf
changed the title
jcjgraf
force-pushed
the
test_memalloc
branch
from
6316a1a to
31fe087
Compare
This was referenced Nov 29, 2024
wipawel
reviewed
Dec 1, 2024
|
The code LGTM. Just some nitpicks for the commit message. Please sign-off commits. Squash the second commit into the first. And try not to use long line in the commit message (max 80-100 chars). After these changes I will merge the test. Thank a lot! |
Repeatedly allocate and map, deallocate and unmape a number of pages/frames. With the current mainline version, this test either causes an assertion in the PMM or locks-up (deadlock?). Signed-off-by: Jean-Claude Graf <[email protected]>
jcjgraf
force-pushed
the
test_memalloc
branch
from
6b1ebdc to
a44dcb6
Compare
|
Shoud be ready to merge now. I am trying to fix the compilation errors in the meantime. So that the pipeline does not break anymore |
wipawel
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a testcase to the unittest that repeatedly allocate and map, deallocate and unmape a number of pages/frames. With the current mainline version, this test either causes an assertion in the PMM (#342) or locks-up (deadlock?) (#343)
The two macros can be used to configure the allocation pattern. Most importantly, changing it to
KT2_ROUNDS 1,KT2_CHUNKS 1000still leads to the same error, indicating that unmaping/dealocation is not the cause of the issue.EDIT: CI compilation fails due to
-Werrorof unrelated code.