Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dump_pagetables() functionality #314

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

wipawel
Copy link
Contributor

@wipawel wipawel commented Nov 2, 2023

No description provided.

@wipawel wipawel added improvement A small enhancement, that makes already implemented features better cleanup labels Nov 2, 2023
@wipawel wipawel requested a review from a team as a code owner November 2, 2023 12:08
Copy link
Contributor

@sktt sktt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from here, just pointing out the FIXME's that can now use the merged warning macro

arch/x86/pagetables.c Outdated Show resolved Hide resolved
arch/x86/pagetables.c Outdated Show resolved Hide resolved
@sktt sktt self-assigned this Nov 5, 2023
Make the dump_pagetables() self-sufficient by having it map the
page tables it traverses automatically.

Refactor and simplify code by extracting common functionality
into separate inline functions.

Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
These functionality dumps the current state of page tables for
specified CR3 only for a given virtual address.

Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
@wipawel wipawel merged commit 5958e59 into KernelTestFramework:mainline Nov 7, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup improvement A small enhancement, that makes already implemented features better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants