Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement API to find the frame for a given virtual address #313

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

wipawel
Copy link
Contributor

@wipawel wipawel commented Nov 2, 2023

This implements #202.

@wipawel wipawel added feature New feature or request devel Development effort Priority: 3 Regular feature labels Nov 2, 2023
@wipawel wipawel requested a review from minipli-oss November 2, 2023 11:02
@wipawel wipawel requested a review from a team as a code owner November 2, 2023 11:02
@wipawel wipawel linked an issue Nov 2, 2023 that may be closed by this pull request
arch/x86/pagetables.c Show resolved Hide resolved
mm/pmm.c Show resolved Hide resolved
mm/pmm.c Show resolved Hide resolved
mm/pmm.c Show resolved Hide resolved
mm/pmm.c Show resolved Hide resolved
mm/pmm.c Show resolved Hide resolved
include/mm/pmm.h Show resolved Hide resolved
Copy link
Contributor

@sktt sktt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I resolved a few comments. One question mainly remains

include/mm/pmm.h Show resolved Hide resolved
mm/pmm.c Show resolved Hide resolved
sktt
sktt previously approved these changes Nov 8, 2023
@wipawel wipawel force-pushed the get_frame branch 2 times, most recently from 256a324 to 00e126f Compare November 14, 2023 12:36
Copy link
Contributor

@minipli-oss minipli-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only minor changes needed.

include/mm/pmm.h Outdated Show resolved Hide resolved
arch/x86/pagetables.c Outdated Show resolved Hide resolved
arch/x86/pagetables.c Outdated Show resolved Hide resolved
arch/x86/pagetables.c Show resolved Hide resolved
The functions traverse specified page tables and obtain a MFN and frame
order for a specified virtual address.

Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
@wipawel wipawel merged commit 1885dfb into KernelTestFramework:mainline Nov 21, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devel Development effort feature New feature or request Priority: 3 Regular feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] API to find the frame for a given virtual address
3 participants