General improvements and cleanup to page tables handling #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wipawel
added
improvement
minipli-oss
reviewed
Oct 24, 2023
They have to be mapped in the new kernel page tables anyway. This is needed to get rid of initial map_used_memory(). Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
The multiboot areas are used to determine invalid physical addresses and MFNs. Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
This is mainly refactoring cleanup. Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
This is mainly refactoring cleanup. Boot stack is part of .bss.init section and as such is mapped. Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Since all necessary pages have been mapped, no need to map anything else. Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Rename it to more correct tmp_map_mfn() and make it an inline function. Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Instead of doing full page table walk to obtain PTE of the temp. mapping location, cache it in _tmp_mapping_entry variable. The variable needs to be set once before construction of the page tables begins and updated once before the switch to new page tables (the virtual address of the PTE changes). Also, there is no need to map in all levels of the page tables for the _tmp_mappings, since the entry address is cached. Map only the last level page table. Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Use INVLPG instead. Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
minipli-oss
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to implement #308 properly.