Further fixes for usermode handling #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to preserve user stack address on percpu first, to use allow simple stack switching. We need to switch to user pagetables before putting IRET frame onto user stack. Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
minipli-oss
reviewed
Aug 28, 2023
minipli-oss
reviewed
Aug 28, 2023
minipli-oss
reviewed
Aug 28, 2023
minipli-oss
previously approved these changes
Aug 28, 2023
The exception handlers as well as interrupt handlers need to be properly mapped into user pagetables. Add global symbols to find their addresses and align the beginning on a page boundary. Similar entry_usermode() and syscall_handler_entry() need to be aligned and ideally share the same page. The syscall_exit() and similar routines do not need user pagetable mappings. Add also an explicit mapping for user_cr3 variable. Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
minipli-oss
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #284. Please review the #284 first and rebase this one to limit the changes.
Only top 3 commits differ.