Automatically generate structure member offsets for assembly #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wipawel
added
the
improvement
Generate offsets of selected structure members to be used in assembly files. The asm-offsets.c file is compiled into assembly (.s) file and parsed by asm-offsets.sh script to generate the final include header asm-offsets.h. This is needed to be able to access per-cpu variables in assembly. Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Now that we have the asm-offsets.h generated for the per-cpu variable, we can use it directly instead of passing argument from the C code. Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
|
I reviewed these commits in #284, see my comments there, starting at #284 (review) |
Splitting cpu_regs_t into cpu_exc_t and cpu_regs_t using cpu_exc_t allows to create asm-offset entries for the struct members to be used directly in entry.S (allows to use different structure offsets when in exception handler and when in syscall). Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate offsets of selected structure members to be used in assembly files.
The asm-offsets.c file is compiled into assembly (.s) file and parsed by asm-offsets.sh script to generate the final include header asm-offsets.h.
This is needed to be able to access per-cpu variables in assembly.