drivers: add basic framebuffer support #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wipawel
commented
Feb 19, 2022
wipawel
commented
- add detection and initialization of a framebuffer (currently RGB color mode is assumed)
- add simple 8x8 fonts
- add logo drawing functionality
- add console output to framebuffer video memory (this allows to use KTF on UEFI systems without serial)
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
82marbag
reviewed
Feb 21, 2022
drivers/fb/logo.c
Outdated
| * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
| */ | ||
|
|
||
| unsigned char logo[] = { |
There was a problem hiding this comment.
Maybe a comment on how it was generated?
There was a problem hiding this comment.
It's basically a Copy and Past as C code from 010 Editor's opened BMP file.
| @@ -123,7 +123,7 @@ ifeq ($(CONFIG_ACPICA),y) | |||
| COMMON_FLAGS += -DKTF_ACPICA | |||
| endif | |||
|
|
|||
| AFLAGS := $(COMMON_FLAGS) -D__ASSEMBLY__ -nostdlib -nostdinc | |||
| AFLAGS := $(COMMON_FLAGS) -DASM_FILE -D__ASSEMBLY__ -nostdlib -nostdinc | |||
There was a problem hiding this comment.
the official multiboot.h file we use uses ASM_FILE to distinguish between C and asm. We use __ASSEMBLY__, but I do not want to modify the original file.
82marbag
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.