add VIRT_KERNEL_MAP memory area #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wipawel
commented
Jan 19, 2022
•
wipawel
commented
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
wipawel
added
the
improvement
| @@ -196,6 +212,19 @@ static inline void *kmap(mfn_t mfn, unsigned int order, | |||
| l3_flags, l2_flags, l1_flags); | |||
| } | |||
|
|
|||
| static inline void *mmap(mfn_t mfn, unsigned int order, | |||
There was a problem hiding this comment.
Same here
name mmap is misleading.
There was a problem hiding this comment.
Ok. Suggestions welcome.
There was a problem hiding this comment.
With VIRT_KERNEL_MAP I hope it's now ok.
The VIRT_KERNEL_MAP is currently located at the address 0xffff800000000000. The memory area should be used for high-address or large memory allocations. The VIRT_KERNEL_BASE area, while reachable from within the VIRT_IDENT_BASE area, does not have enough addressing space for high address allocations (base address overflow). All such allocations should go to the new area. Add mmap() helper (or its order size variants) to automatically use the VIRT_KERNEL_MAP area. The get_free_pages() gets a new flag GPF_KERNEL_MAP to use the area. Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
82marbag
previously approved these changes
Jan 20, 2022
82marbag
approved these changes
Jan 20, 2022
wipawel
changed the title
dkgupta-amzn
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.