Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Libpfm building with KTF #217

Merged
merged 7 commits into from
Oct 8, 2021

Conversation

wipawel
Copy link
Contributor

@wipawel wipawel commented Oct 8, 2021

Description of changes:

Several changes were needed to build libpfm and link it with KTF.
Most important is: f2b2c80.
Majority of the changes are fixes and cleanups to the Makefile.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

wipawel and others added 7 commits October 8, 2021 14:52
Libpfm upon build creates many additional .text.* and .data.* sections.
Combine and place them into the main ones: .text and .data.

Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Previously it only worked when LIBPFM was enabled in the config.
There was also a bug in the patched-in Makefile cleanlib target.

Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
KTF code has dependency to libpfm, so libpfm must be built
first.

Signed-off-by: Pawel Wieczorkiewicz <[email protected]>
Copy link
Contributor

@dkgupta-amzn dkgupta-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dkgupta-amzn dkgupta-amzn merged commit a6ff573 into KernelTestFramework:mainline Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants