setup: use tail-call for kernel_main jump #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pawel Wieczorkiewicz <[email protected]> Suggested-By: Mathias Krause <[email protected]>
82marbag
approved these changes
Oct 8, 2021
minipli-oss
reviewed
Oct 8, 2021
| @@ -300,7 +300,7 @@ void __noreturn __text_init kernel_start(uint32_t multiboot_magic, | |||
| init_keyboard(get_bsp_cpu_id()); | |||
|
|
|||
| /* Jump from .text.init section to .text */ | |||
| asm volatile("push %0; ret" ::"r"(&kernel_main)); | |||
| asm volatile("jmp kernel_main"); | |||
There was a problem hiding this comment.
Why not simply drop the inline ASM and call kernel_main() as it's supposed to be?:
kernel_main();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pawel Wieczorkiewicz [email protected]
Suggested-By: Mathias Krause [email protected]
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.