Skip to content

Commit

Permalink
one-line-cr-bot: commenting PRs beta
Browse files Browse the repository at this point in the history
The next feature is to comment on PRs instead of writing defects to the
workflow output. To do so, we need to use the new development branch.
Furthermore, we need github support in python. Finally, let's not use
the system cppcheck, but the most recent one.

Signed-off-by: Norbert Manthey <[email protected]>
  • Loading branch information
nmanthey authored and wipawel committed Oct 26, 2020
1 parent b757afb commit 507ccb5
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions .github/workflows/one-line-cr-bot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,13 @@ jobs:
fetch-depth: 0

# one-line-cr-bot.sh will get infer and cppcheck, if not available
- name: Install CppCheck Package
- name: Install Required Packages
env:
# This is needed in addition to -yq to prevent apt-get from asking for user input
DEBIAN_FRONTEND: noninteractive
# [ACTION REQUIRED] Add your build dependencies here, drop cppcheck to get latest cppcheck
# [ACTION REQUIRED] Add your build dependencies here
run: |
sudo apt-get install -y cppcheck
sudo apt-get install -y python3-github
# Get the compare remote
- name: Setup Compare Remote
Expand All @@ -48,7 +48,7 @@ jobs:

# Get one-line-scan, the tool we will use for analysis
- name: Get OneLineScan
run: git clone -b one-line-cr-bot https://github.com/nmanthey/one-line-scan.git ../one-line-scan
run: git clone -b comment-prs https://github.com/nmanthey/one-line-scan.git ../one-line-scan

# Check how repository is setup
- name: Be Verbose about Git Setup
Expand All @@ -71,9 +71,11 @@ jobs:
# Additional Infer parameters, do not use e.g. --pulse
INFER_ANALYSIS_EXTRA_ARGS: "--bufferoverrun"
# These settings are more preferences, and not directly related to your project
# Set INSTALL_MISSING to false, if ALL targetted tools are already present
# Set INSTALL_MISSING to false, if ALL targeted tools are already present
IGNORE_ERRORS: false
INSTALL_MISSING: true
OVERRIDE_ANALYSIS_ERROR: true
POST_TO_GITHUB_PR: true
REPORT_NEW_ONLY: true
VERBOSE: 0 # >0 shows all currently present defects as well
# Be explicit about the tools to be used
Expand Down

0 comments on commit 507ccb5

Please sign in to comment.