refactor: 이미지 변환 의존성 변경 #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soeunnPark
reviewed
Nov 28, 2024
| return outputStream.toByteArray(); | ||
| } catch (IOException exception) { | ||
| log.error("Image conversion failed for file: {}", file.getOriginalFilename(), exception); |
There was a problem hiding this comment.
로그는 Exception Handler에서만 남겨야 중복이 발생하지 않습니다.
There was a problem hiding this comment.
Exception Handler 에 로그를 남기면 ClooudWatch에서 로그가 확인되지 않아 남겼습니다. 이슈를 해결했으니 지우겠습니다 😄
There was a problem hiding this comment.
Exception Handler 에 남긴 로그가 Cloud Watch에서 확인되지 않는군요!! 확인해보겠습니다 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR에 대한 설명 🔍
위의
scrimage의존성은WebpWriter가 내부적으로 사용하는cwebp바이너리가GLIBC버전을 충족하지 못해서 배포 환경에서 이미지 업로드를 실패합니다.위의 이슈를 해결하기 위해
implementation 'com.twelvemonkeys.imageio:imageio-webp:3.9.4'위의
twelvemonkeys를 사용해서 이미지 업로드를 수정했습니다. 그러나twelvemonkeys의존성을 사용하면 이미지를webp로 변환을 할 때 이미지가 손상되는 이슈가 발생합니다.QA 를 진행하기 위해 임시로
twelvemonkeys를 사용하고 추후 어떻게 해야 할 지함께 고민해봐야 할 것 같습니다.