Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 스크랩, 대시보드 페이지 로그인 모달 x 버튼 클릭시 홈으로 리다이렉트 #301

Merged
merged 3 commits into from
Nov 22, 2024
Merged

fix: 스크랩, 대시보드 페이지 로그인 모달 x 버튼 클릭시 홈으로 리다이렉트 #301

merged 3 commits into from
Nov 22, 2024

Conversation

smosco
Copy link
Collaborator

@smosco smosco commented Nov 22, 2024

📄 Description of the PR

🔧 What has been changed?

📸 Screenshots / GIFs (if applicable)

⚠️ Precaution & Known issues

✅ Checklist

  • UI 브랜치 같이 확인해서 이슈없는지 확인해보기
  • 함수 이름, 변수 이름만 봐도 어떤 기능을 하는지 파악할 수 있는지 (선언적인 코드인지 확인)

@smosco smosco self-assigned this Nov 22, 2024
@smosco smosco linked an issue Nov 22, 2024 that may be closed by this pull request
[fix] scrap, dashboard login modal redirect #300
Closed
3 tasks
godhyzzang
godhyzzang approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@godhyzzang godhyzzang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

모달 컴포넌트 자체에 x버튼이 있고 여기에 onClose가 전달되는 구조였었죠? 순간 x버튼 코드에는 왜 변경이 없지하고 착각했네요~ 수고하셨습니다

@smosco smosco merged commit b713694 into develop Nov 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godhyzzang godhyzzang godhyzzang approved these changes

Assignees

@smosco smosco

Labels
🌝 fe 🐞 fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fix] scrap, dashboard login modal redirect
2 participants
@smosco @godhyzzang