[15.0][MIG] account payment order #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the Sorrento Code sprint 2016 Improvements include: - full re-organisation of modules and big re-organisation of the code - simplification of the code related to the fact that support for direct debit is now in t he base module, not added by an optional module account_direct_debit (module was removed) - new design of the wizard to select move lines to pay - support for non-SEPA file transfer- - support for German direct debit SEPA files (fixes bug OCA#129) - remove workflow of payment.order - add wizard of selection of move lines to pay
* IMP: prevent deleting a move-line that is linked to a payment order line * FIX: better filtering of move lines already included in open payment order
Take into account all the remaining remarks of Frederic Clementi dated May 30: - see multi-currency amounts in the wizard to add transaction lines - add help msg on bank payment lines
* IMP: extensibility of _prepare_move Pass the list of bank lines to _prepare_move so it is possible to customize the move (eg it's name) based on the lines being paid. * FIX: payment order: add missing onchange dependencies in move selection wizard
* Fix crash when selecting a customer that has a direct debit payment mode but no mandate * Hide many fields when payment_order_ok is False on a payment_mode * Fix payment line communication when the move line is not linked to an invoice (problem found when porting donation_debit_debit to v9) * For the communication field, if self.move_id.ref is False, fallback on self.move_id.name
Port almost all modules to v10 * Update to EPC Rulebook v9.2 that start to apply on 2016-11-20 (bug OCA#300)
* FIX: Bug OCA#353 crash when selecting a payment mode that has a variable link to a bank account * FIX: Add 'post_move' option on account.payment.mode with default True, to keep the previous behavior * IMP: Explicit error when bank account is missing on bank journal * IMP: Add field default_date_prefered on payment mode.
…ent order + allow to cancel an uploaded payment order
* Restrict the deletion of bank payment line * Add test_cancel_payment_order
context of payment orders, she should ocus on the amount that is due to be paid. In this method we are forcing to display both the amount due in company and in the invoice currency. We then hide the fields debit and credit, because they add no value.
When adding to a payment order from invoices, the payment mode considered is the one in the invoice, but once you have confirmed it, you can't change it, so if you change the payment mode in the journal items, it doesn't make the difference. With this change, this is taken into account for adding to the payment order(s) properly.
- when manually encoding a payment line, get company currency as default currency - Search on payment order numbers - Direct search on bank journal name in payment orders - remove widget="selection" on account.payement.mode : this object is rarely modified, so widget='selection' is not a time saver, but we miss the HTML link, which can be pretty convenient to check the configuration.
Currently translated at 86.8% (192 of 221 strings) Translation: bank-payment-14.0/bank-payment-14.0-account_payment_order Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_payment_order/fr_FR/
After odoo/odoo@fcaa549, we need to specify the invoice date for vendor bills to be able to post it
Currently translated at 91.4% (202 of 221 strings) Translation: bank-payment-14.0/bank-payment-14.0-account_payment_order Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_payment_order/fr_FR/
…a value We should assign a value for all records of the set.
Currently translated at 49.3% (109 of 221 strings) Translation: bank-payment-14.0/bank-payment-14.0-account_payment_order Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_payment_order/es_CL/
Currently translated at 100.0% (221 of 221 strings) Translation: bank-payment-14.0/bank-payment-14.0-account_payment_order Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_payment_order/es/
Currently translated at 100.0% (221 of 221 strings) Translation: bank-payment-14.0/bank-payment-14.0-account_payment_order Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_payment_order/es_CL/
Currently translated at 100.0% (221 of 221 strings) Translation: bank-payment-14.0/bank-payment-14.0-account_payment_order Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_payment_order/es_CL/
Currently translated at 68.1% (150 of 220 strings) Translation: bank-payment-14.0/bank-payment-14.0-account_payment_order Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_payment_order/nl/
Currently translated at 70.4% (155 of 220 strings) Translation: bank-payment-14.0/bank-payment-14.0-account_payment_order Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_payment_order/nl/
…e when offsetting_account is bank_account
Before this change, the group was creating a new section in each user's settings called "Other" with a field called "Other Extra Rights" that could select "Accounting / Payments" as an option This places it in the correct location TT29182
…t modes When the generate_moves option is not selected, the post_move option should not be available TT29182
Current spec was causing weird display in account move view, both for customer invoices and vendor bills Changing the placement and adding back the label fixes the issue TT29027
…t_domain mehtod to find move in a method.
Use base `account` tests from Odoo to avoid issues with the environment.
dnplkndll
commented
Nov 1, 2021
| "%d payment lines added to the new draft payment " | ||
| "order %s which has been automatically created." | ||
| "%(count)d payment lines added to the new draft payment " | ||
| "order %(payorder.name)s which has been automatically created." |
There was a problem hiding this comment.
@wlin-kencove do you know if this syntax works?
There was a problem hiding this comment.
@dnplkndll
I am more used to seeing the parameterized % or f(string) formatting. This method should work as well, though it is usually accompanied by a dictionary that maps the values.
I am expecting something that looks like the example below:
body = _(%(count)d payment lines added to the new draft payment "
"order %(payorder.name)s which has been automatically created." %
{
"count": count,
"payorder.name": payorder.name
}
)
There was a problem hiding this comment.
@dnplkndll
I could be mistaken if this is a new way of formatting strings, but they do look similar (except for the missing dictionary).
I do see it implemented in a later code segment:
So perhaps missed in this section?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.