Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Upgrade to Vue 3 and Vuetify 3. #56

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

Kelketek
Copy link
Owner

@Kelketek Kelketek commented Nov 7, 2023

Upgrades the frontend to use Vue 3 alongside Vuetify 3 and Vuex 4.
Migrates the build system to Vite 5. This also resulted in several
small improvements such as:

  1. Reduced payload by removing no-longer-needed workaround code for things Vuetify and Vue now natively support.

  2. Also removed code for Credit card number validation/type determination on the frontend, which hasn't been needed since we moved to Stripe from Authorize.net.

  3. Removes many, perhaps most, direct dependencies on the frontend.

  4. Increases build speed significantly. Expected to increase even further once Vite replaces rollup.

  5. Bifurcated the download button on Submissions so that you can choose to either use your browser's built-in viewer or else actually download the file to disk.

  6. As an adjunct to 5, removed the 'zoom' feature for clicking on a submission, since our built-in zoom viewer never quite worked consistently, and the view button tends to create a better experience.

  7. Removed 'floating action buttons'-- which aren't supported by our component framework anymore. These were primarily used on mobile to make those green buttons with a plus sign on them for adding stuff.

    People often didn't notice them anyway, for some reason, so now the button that appears on desktop appears on mobile, too, and those buttons are gone. Same with the blue editor toggle.

  8. New content rating selector replaces old one to make it more obvious how it works and less easy to miss when fiddling with your settings.

  9. Turned the upload revision form into a modal instead of just automatically creating a revision when the image is uploaded. You can also now submit a comment alongside the revision so you can do this in one go. It also makes it more obvious that you can (and should, when appropriate) mark the revision as the final.

@Kelketek Kelketek force-pushed the fox/upgrade-frontend branch 2 times, most recently from aa83eb2 to 57e0db1 Compare November 25, 2023 16:31
@Kelketek Kelketek force-pushed the fox/upgrade-frontend branch from 152a5bc to 490ae6d Compare December 7, 2023 20:11
@Kelketek Kelketek force-pushed the fox/upgrade-frontend branch 2 times, most recently from 66fd766 to ea2a37c Compare December 19, 2023 18:47
@Kelketek Kelketek force-pushed the fox/upgrade-frontend branch 2 times, most recently from 30eb6d9 to e89ae25 Compare December 31, 2023 21:33
@Kelketek Kelketek force-pushed the fox/upgrade-frontend branch from 2547dae to 2756929 Compare January 6, 2024 16:57
@Kelketek Kelketek force-pushed the fox/upgrade-frontend branch 6 times, most recently from 44688ae to a388719 Compare January 29, 2024 17:39
@Kelketek Kelketek force-pushed the fox/upgrade-frontend branch 2 times, most recently from 4ee6c4d to 521c8c0 Compare January 30, 2024 10:24
Upgrades the frontend to use Vue 3 alongside Vuetify 3 and Vuex 4.
Migrates the build system to Vite 5. This also resulted in several
small improvements such as:

1. Reduced payload by removing no-longer-needed workaround code for
   things Vuetify and Vue now natively support.
2. Also removed code for Credit card number validation/type
   determination on the frontend, which hasn't been needed since we
   moved to Stripe from Authorize.net.
3. Removes many, perhaps most, direct dependencies on the frontend.
4. Increases build speed significantly. Expected to increase even
   further once Vite replaces rollup.
5. Bifurcated the download button on Submissions so that you can choose
   to either use your browser's built-in viewer or else actually
   download the file to disk.
6. As an adjunct to 5, removed the 'zoom' feature for clicking on a
   submission, since our built-in zoom viewer never quite worked
   consistently, and the view button tends to create a better experience.
7. Removed 'floating action buttons'-- which aren't supported by our
   component framework anymore. These were primarily used on mobile to
   make those green buttons with a plus sign on them for adding stuff.

   People often didn't notice them anyway, for some reason, so now the
   button that appears on desktop appears on mobile, too, and those buttons
   are gone. Same with the blue editor toggle.
8. New content rating selector replaces old one to make it more obvious
   how it works and less easy to miss when fiddling with your settings.
9. Turned the upload revision form into a modal instead of just
   automatically creating a revision when the image is uploaded. You can
   also now submit a comment alongside the revision so you can do this in
   one go. It also makes it more obvious that you can (and should, when
   appropriate) mark the revision as the final.
@Kelketek Kelketek force-pushed the fox/upgrade-frontend branch from 521c8c0 to 867ad91 Compare January 30, 2024 11:48
@Kelketek Kelketek merged commit 867ad91 into master Jan 30, 2024
1 check passed
@Kelketek Kelketek changed the title [WIP] refactor: Upgrade to Vue 3 and Vuetify 3. refactor: Upgrade to Vue 3 and Vuetify 3. Jan 30, 2024
@Kelketek Kelketek deleted the fox/upgrade-frontend branch January 30, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant