Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UrlDispatcher error during constructing of url with regex parts #264

Closed
imbolc opened this issue Jan 29, 2015 · 6 comments
Closed

UrlDispatcher error during constructing of url with regex parts #264

imbolc opened this issue Jan 29, 2015 · 6 comments
Assignees

Comments

@imbolc
Copy link
Contributor

imbolc commented Jan 29, 2015

>>> from aiohttp.web import UrlDispatcher
>>> disp = UrlDispatcher()
>>> disp.add_route('GET', '/{num:^\d+}', lambda x: x, name='name')
<DynamicRoute 'name' [GET] /{num:^\d+} -> <function <lambda> at 0x7f0223131840>
>>> disp['name'].url(parts={'num': '1'})
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/imbolc/.pyenv/versions/3.4.1/lib/python3.4/site-packages/aiohttp/web.py", line 1226, in url
    url = self._formatter.format_map(parts)
ValueError: Invalid format specifier



@fafhrd91
Copy link
Member

@asvetlov stop making one change releases. it doesnt make sense right now.

@imbolc
Copy link
Contributor Author

imbolc commented Jan 29, 2015

@fafhrd91 what is bad? At least I don't need to change pip requirements from aiohttp to git+....

@fafhrd91
Copy link
Member

release every couple days seems like spam. and do you have gcc and cython on your production servers?

On Jan 29, 2015, at 12:52 PM, Imblc [email protected] wrote:

@fafhrd91 https://github.com/fafhrd91 what is bad? At least I don't need to change pip requirements from aiohttp to git+....


Reply to this email directly or view it on GitHub #264 (comment).

@imbolc
Copy link
Contributor Author

imbolc commented Jan 29, 2015

Yes, I do. But I don't think, I should to update my production servers for
each release :)

On Fri, Jan 30, 2015 at 3:55 AM, Nikolay Kim [email protected]
wrote:

release every couple days seems like spam. and do you have gcc and cython
on your production servers?

On Jan 29, 2015, at 12:52 PM, Imblc [email protected] wrote:

@fafhrd91 https://github.com/fafhrd91 what is bad? At least I don't
need to change pip requirements from aiohttp to git+....


Reply to this email directly or view it on GitHub <
https://github.com/KeepSafe/aiohttp/issues/264#issuecomment-72101742>.


Reply to this email directly or view it on GitHub
#264 (comment).

@asvetlov
Copy link
Member

From my perspective making a bugfix release as soon as bug has fixed makes
no harm.

But, if you don't like it, I can wait for next month for new update.

On Thu, Jan 29, 2015 at 11:00 PM, Imblc [email protected] wrote:

Yes, I do. But I don't think, I should to update my production servers for
each release :)

On Fri, Jan 30, 2015 at 3:55 AM, Nikolay Kim [email protected]
wrote:

release every couple days seems like spam. and do you have gcc and
cython
on your production servers?

On Jan 29, 2015, at 12:52 PM, Imblc [email protected] wrote:

@fafhrd91 https://github.com/fafhrd91 what is bad? At least I don't
need to change pip requirements from aiohttp to git+....


Reply to this email directly or view it on GitHub <
https://github.com/KeepSafe/aiohttp/issues/264#issuecomment-72101742>.


Reply to this email directly or view it on GitHub
#264 (comment).


Reply to this email directly or view it on GitHub
#264 (comment).

Thanks,
Andrew Svetlov

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants