This repository has been archived by the owner on Mar 29, 2019. It is now read-only.
Fixed setExtendedAccessToken - FB API returns JSON and not a parse_str compatible string #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r compatible string
|
It is probably the same case as f20e57f |
|
Yeah, it has to be fixed like f20e57f - it's safer. @ondrejmirtes what version of FB API are you using? |
|
Will it be fixed in master? It's very easy fix. As you said, it's the same as f20e57f and it could be fixed the same way. Method is not working since v2.3 graph API (so v2.2 still works ok). |
|
@hermamat indeed it is, but seems like nobody cares enough to send a PR :) |
fprochazka
added a commit
that referenced
this pull request
Jan 17, 2016
fprochazka
added a commit
that referenced
this pull request
Jan 17, 2016
|
@fprochazka Thanks. Sorry, I'm very new to github and to web programming, so I'm not sure if I could handle push requests properly and I'm really not sure about writing proper clean code, but maybe I should tried it O:) |
|
@hermamat I would have been happy to guide you :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if it depends on FB API version or something, but this method did not work in our app until I fixed it to decode JSON.