-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Adding cycling indent *NOT READY FOR MERGE* #1
Conversation
jackcviers
commented
Jan 5, 2022
- Functionality conceptually complete (haven't tested it yet)
- Trying to figure out how to test this with ERT before I QA it.
* Functionality conceptually complete (haven't tested it yet) * Trying to figure out how to test this with ERT before I QA it.
Ok. So I've been looking at how haskell-tng.el did their indentation tests, how scalafmt does its indentation tests, and so on. I have an idea for creating a set of indentation tests for this repo based upon the ideas there, but it's probably overkill for my toggle, and probably needs to be a separate pr for this package. I will get some ert tests that use a demo scala buffer by tomorrow afternoon, then hopefully we can discuss this with the finished poc. |
@Kazark So I have it cycling between 0 and |
I haven't added tests, but I have verified it at several indent levels. One thing that's weird for me is that
and debug-on-error isn't giving me a backtrace. I don't think I touched that, so not sure what's going on here. |
@jackcviers Hey sorry for the no-show here. I lost momentum on my Scala 3 work because this is a blocker for me. I will try to take a look at this soon though and at least merge it into my branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change very much looks additive to me. I can't see how it can break my stuff, and it looks well done as far as I can tell. Thank you. I will merge it into my branch. Feel free to send follow-up PRs.
I definitely have some bugs still on my branch that need to be worked out.
emacs-scala-mode/scala-mode-indent.el Lines 995 to 997 in 35f265f
|
Incorrect order of arguments causes wrong type argument error in scala-indent:indent-line. Swapping argument order fixes the error reported by @jj1uzh [here](Kazark#1 (comment)).
Incorrect order of arguments causes wrong type argument error in scala-indent:indent-line. Swapping argument order fixes the error reported by @jj1uzh [here](Kazark#1 (comment)).