Initial implementation of IBC Precompile #37
Conversation
evgeniy-scherbina
force-pushed
the
yevhenii/ibc-precompile
branch
from
7fb6ed5 to
8afb4f7
Compare
| func (s *StateDB) Context() context.Context { | ||
| // s.ctx.CurrentCtx() replaced s.ctx after rebasing | ||
| // TODO(yevhenii): is it correct? | ||
| return s.ctx.CurrentCtx() |
There was a problem hiding this comment.
Yup this is the correct ctx of the active snapshot to use for making state changes
x/evm/statedb/statedb.go
Outdated
| @@ -464,3 +472,12 @@ func (s *StateDB) SetError(err error) { | |||
|
|
|||
| s.sdkError = err | |||
| } | |||
|
|
|||
| func (s *StateDB) IBCTransfer(goCtx context.Context, msg *ibctransfertypes.MsgTransfer) (*ibctransfertypes.MsgTransferResponse, error) { | |||
There was a problem hiding this comment.
It feels a bit out of place for IBCTransfer() to be in the statedb, but does seem to make it easier to add access to the keepers without breaking more things in geth.
To me I think it makes a bit more sense to pass in additional keepers to geth vm.NewEVM() then provide the matching keeper interface in contract.accessibleState. Since it doesn't seem needed by StateDB or the Ethermint keepers? (pls correct me if wrong)
Just cuts out an extra step passing the keepers around like so:
Kava -> Ethermint -> EVM -> Custom precompile
Kava -> EVM -> Custom precompile
There was a problem hiding this comment.
sounds reasonable, the only downside is changing func NewEVM(...) *EVM signature will be a bit painful, it's widely used across go-ethereum codebase (40 direct occurrences)
cc @nddeluca
evgeniy-scherbina
force-pushed
the
yevhenii/ibc-precompile
branch
3 times, most recently
from
d5fc637 to
457e857
Compare
evgeniy-scherbina
force-pushed
the
yevhenii/ibc-precompile
branch
from
457e857 to
f6c748c
Compare
|
@Mergifyio refresh |
✅ Pull request refreshed |
Based on #32