Fixes #38104 - Hide Media when Synced Content is selected #11263
+10
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Instead of loading the script inside content_for(:javascripts) , load it in the file, but add the checks to make sure it runs after KT.hosts exists.
Considerations taken when implementing this change?
Didn't find another <script> that could be effected by it.
The issue is when os is selected (os_selected request) it returns part of the page, and the selectors and eventlisteners need to bind again. after getting only part of the page content_for is not loaded again
What are the testing steps for this pull request?
to reproduce have a kickstarter repo and create a hostgroup, select the matching Content Source, Lifecycle Environment, Content View, go to the os tab, select Architecture and the OS that was created from the kickstart repo, when selecting the Synced Content radio, media should disappear but it does not