Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #38102 - Auth token of flatpak-remote shouldn't be returned by API #11261

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sjha4
Copy link
Member

@sjha4 sjha4 commented Dec 13, 2024

What are the changes introduced in this pull request?

Don't return token of flatpak remote on the API

Considerations taken when implementing this change?

What are the testing steps for this pull request?

Go to katello/api/v2/flatpak_remotes/ and make sure you don't see the authentication token.

Copy link

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the patch locally and looks good to me - no token was returned:

$ curl -sku lojza:changeme -H "Content-type: application/json" -X GET https://satellite.redhat.com/katello/api/flatpak_remotes/2 | jq
{
  "name": "CUzimMsarr",
  "url": "https://flatpaks.redhat.io/rhel/",
  "description": null,
  "username": "1234567|wonderful-tokenauth",
  "seeded": false,
  "registry_url": "https://registry.redhat.io/",
  "id": 2,
  "organization_id": 4,
  "organization": {
    "name": "LBrOQnkgYtXs",
    "label": "LBrOQnkgYtXs",
    "id": 4
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants