Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap Jaccard and some "algorithms" from PropertyFileGraph.h #5

Merged
merged 5 commits into from
Jan 8, 2021
Merged

Wrap Jaccard and some "algorithms" from PropertyFileGraph.h #5

merged 5 commits into from
Jan 8, 2021

Conversation

arthurp
Copy link
Contributor

@arthurp arthurp commented Dec 31, 2020

Ported from KatanaGraph/katana-enterprise#735

@arthurp arthurp requested a review from gurbinder533 December 31, 2020 05:03
@arthurp arthurp force-pushed the feature/wrap-jaccard branch from 50241e6 to e7cd436 Compare January 8, 2021 17:48
gurbinder533
gurbinder533 approved these changes Jan 8, 2021
View reviewed changes
Copy link
Contributor

@gurbinder533 gurbinder533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for a few minor things.

@arthurp arthurp force-pushed the feature/wrap-jaccard branch from c22cd8d to 0ad61a0 Compare January 8, 2021 20:05
@arthurp arthurp mentioned this pull request Jan 8, 2021
Open
@arthurp arthurp merged commit 3f894f1 into KatanaGraph:master Jan 8, 2021
@arthurp arthurp deleted the feature/wrap-jaccard branch January 11, 2021 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurbinder533 gurbinder533 gurbinder533 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arthurp @gurbinder533