Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version script to handle more corner cases. #174

Merged
merged 2 commits into from
Apr 25, 2021

Conversation

arthurp
Copy link
Contributor

@arthurp arthurp commented Apr 22, 2021

This is based on an issue encountered by @narendrachaudhary51.

@arthurp arthurp requested a review from ddn0 April 22, 2021 17:00
scripts/katana_version/__main__.py Outdated Show resolved Hide resolved
scripts/katana_version/__main__.py Show resolved Hide resolved
@arthurp arthurp force-pushed the fix/fail-safe-in-non-git-source branch from e80c170 to 6c56cc9 Compare April 22, 2021 17:48
scripts/katana_version/__main__.py Show resolved Hide resolved
Not important I know. But I did it before catching myself so I might as well commit it.
@arthurp arthurp force-pushed the fix/fail-safe-in-non-git-source branch from 6c56cc9 to 913b742 Compare April 22, 2021 18:56
@arthurp arthurp merged commit 4fb3678 into KatanaGraph:master Apr 25, 2021
@arthurp arthurp deleted the fix/fail-safe-in-non-git-source branch April 25, 2021 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants