Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(options): Validate options passed to the parse function (#29) #44

Merged
merged 6 commits into from
Dec 3, 2020
Merged

feat(options): Validate options passed to the parse function (#29) #44

merged 6 commits into from
Dec 3, 2020

Conversation

soft-decay
Copy link
Contributor

  • Validate input, encoding, and ignoredVisibilities
  • Refactor options in a separate module
  • Add typings for parse options
  • Add tests for options module
  • Add documentation to lib/helpers.js

soft-decay and others added 5 commits November 30, 2020 14:04
@soft-decay
feat(validation): Validate options passed to the parse function
2e959ff 
- Validate input
- Validate encoding
- Validate ignoredVisibilities
- Add typings for parse options
@soft-decay
test(options): Add tests and refactor
7640af7 
- Refactor options in a separate module
- Add tests (12) for options module
- Fix typings for options
- Set options.structure instead of passing param
- Add documentation to lib/helpers.js
@soft-decay
Merge remote-tracking branch 'upstream/master' into feature/parser-op…
4483e0f 
…tions-validation
fix(options): update typings + refactor error messages
44b9a82
fix(options): Add missing error messages
f5d0d39 
- Add default value to printArray
@soft-decay soft-decay mentioned this pull request Dec 2, 2020
Closed
3 tasks
alexprey
alexprey approved these changes Dec 3, 2020
View reviewed changes
Copy link
Collaborator

@alexprey alexprey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! AWESOME WORK!
I'm approve this PR, but left some comments for discussion

lib/options.js Show resolved Hide resolved
lib/parser.js Outdated Show resolved Hide resolved
lib/helpers.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@alexprey alexprey added this to the 4.0.0 milestone Dec 3, 2020
@soft-decay
fix(options): Add integration tests for version auto-detect
a438a40 
- revert detectedVersion => version
- Fix typedef for FileStructure
- Small code changes
- Small test changes
@alexprey alexprey merged commit 3bcb993 into KatChaotic:master Dec 3, 2020
@soft-decay soft-decay deleted the feature/parser-options-validation branch December 3, 2020 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexprey alexprey alexprey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@soft-decay @alexprey