Make toVeloxExpr(Expression) virtual (#11)

Kasma-Inc · Jun 11, 2024 · 41fc7f2 · 41fc7f2
1 parent 95a9e7f
commit 41fc7f2
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/velox/substrait/SubstraitToVeloxExpr.h b/velox/substrait/SubstraitToVeloxExpr.h
@@ -26,6 +26,8 @@ namespace facebook::velox::substrait {
 /// expressions.
 class SubstraitVeloxExprConverter {
  public:
+  virtual ~SubstraitVeloxExprConverter() = default;
+
   /// subParser: A Substrait parser used to convert Substrait representations
   /// into recognizable representations. functionMap: A pre-constructed map
   /// storing the relations between the function id and the function name.
@@ -54,7 +56,7 @@ class SubstraitVeloxExprConverter {
       const ::substrait::Expression::Literal& substraitLit);
 
   /// Convert Substrait Expression into Velox Expression.
-  core::TypedExprPtr toVeloxExpr(
+  virtual core::TypedExprPtr toVeloxExpr(
       const ::substrait::Expression& substraitExpr,
       const RowTypePtr& inputType);