Comments

Karm · May 23, 2024 · 2ae2097 · 2ae2097
1 parent db56f98
commit 2ae2097
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/...tx-http/deployment/src/main/java/io/quarkus/vertx/http/deployment/VertxHttpProcessor.java b/...tx-http/deployment/src/main/java/io/quarkus/vertx/http/deployment/VertxHttpProcessor.java
@@ -574,6 +574,8 @@ void brotliResources(HttpBuildTimeConfig httpBuildTimeConfig,
             } else {
                 v = nativeImageRunnerBuildItem.getBuildRunner().getGraalVMVersion();
             }
+            // Newer 23.1+ GraalVM/Mandrel does not need this explicitly marked for runtime init thanks
+            // to a different strategy: https://github.com/oracle/graal/blob/vm-23.1.0/substratevm/CHANGELOG.md?plain=1#L10
             if (v.compareTo(GraalVM.Version.VERSION_23_1_0) <= 0) {
                 runtimeInitializedClasses
                         .produce(new RuntimeInitializedClassBuildItem("io.netty.handler.codec.compression.Brotli"));

diff --git a/...p/runtime/src/main/java/io/quarkus/vertx/http/runtime/options/HttpServerOptionsUtils.java b/...p/runtime/src/main/java/io/quarkus/vertx/http/runtime/options/HttpServerOptionsUtils.java
@@ -283,7 +283,7 @@ public static void applyCommonOptions(HttpServerOptions httpServerOptions,
                 } else if ("br".equalsIgnoreCase(compressor)) {
                     final BrotliOptions o = StandardCompressionOptions.brotli();
                     // The default compression level for brotli as of Netty Codec 4.1 is 4,
-                    // so we don't pick up Vert X Core 4.5.7's default of 6. User can override:
+                    // so we don't pick up Vert.x Core 4.5.7's default of 6. User can override:
                     if (buildTimeConfig.compressionLevel.isPresent()) {
                         o.parameters().setQuality(buildTimeConfig.compressionLevel.getAsInt());
                     }

diff --git a/...on-tests/vertx-http-compressors/app/src/test/java/io/quarkus/compressors/it/Testflow.java b/...on-tests/vertx-http-compressors/app/src/test/java/io/quarkus/compressors/it/Testflow.java
@@ -48,7 +48,7 @@ public static void runTest(String endpoint, String acceptEncoding, String conten
         final WebClient client = WebClient.create(Vertx.vertx(), new WebClientOptions()
                 .setLogActivity(true)
                 .setFollowRedirects(true)
-                // Vert.X Web Client
+                // Vert.x Web Client
                 // -----------------
                 // Why not use the client's built-in decompression support?
                 // Why you do decompression manually here?