Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate HELIDON_QUICKSTART_SE increased RSS in GHAs. #226

Open
jerboaa opened this issue Nov 24, 2023 · 11 comments
Open

Investigate HELIDON_QUICKSTART_SE increased RSS in GHAs. #226

jerboaa opened this issue Nov 24, 2023 · 11 comments
Assignees

Comments

@jerboaa
Copy link
Collaborator

jerboaa commented Nov 24, 2023

We apparently see a ~2MB increase in RSS size in GHA:

 Error:    RuntimesSmokeTest.helidonQuickStart:228->testRuntime:77->testRuntime:163 
Application HELIDON_QUICKSTART_SE in mode none consumed 78764 kB of RSS memory , which is over 78368 kB threshold by 1%.
 ==> expected: <true> but was: <false>

The reference value for 23.1 is: 76647 Kb This needs to be investigated.

See:
#198 (comment)

@jerboaa
Copy link
Collaborator Author

jerboaa commented Nov 24, 2023

@jerboaa
Copy link
Collaborator Author

jerboaa commented Nov 27, 2023

There has been a threshold bump in #227 but we need to do the threshold handling per quarkus version probably.

@Karm
Copy link
Owner

Karm commented Nov 27, 2023

@jerboaa Helidon has nothing to do with Quarkus. Our Helidon version is very old, the last time we updated Helidon was in April 2021: 9cab8f9

If the RSS is off, it's either:

  • environment, OS
  • or Mandrel

@jerboaa
Copy link
Collaborator Author

jerboaa commented Nov 27, 2023

Which confirms it needs some investigation?

@Karm
Copy link
Owner

Karm commented Nov 27, 2023

Which confirms it needs some investigation?

Indeed. A rare occasion where it seems we have fewer moving parts as the app version is the same.

@zakkak
Copy link
Collaborator

zakkak commented Dec 4, 2023

Running locally I get the following numbers which indicate no significant increase between 23.1, 23.1.1 and graal/master on Linux (I will look into windows next apparently the helidon test is not ran on Windows).

Mandrel version RSS after startup RSS after 4 requests
Mandrel graal/master with JDK 22+25 41472 61184
Mandrel-23.1.1.1-deve19e4e528fd 41472 61440
Mandrel-23.1.0.0-Final 41728 61952
Mandrel-23.0.2.1-Final 40704 59904
Mandrel-22.3.4.0-Final 39936 58624

The 4 requests are:

@zakkak
Copy link
Collaborator

zakkak commented Dec 4, 2023

Interestingly, the only time it passed was in https://github.com/zakkak/mandrel/actions/runs/6944009708/job/18891435883 (while testing before merging the PR that enabled these tests) and according to the logs it used github runner 2.311.0 which is the same runner used in the failing https://github.com/graalvm/mandrel/actions/runs/6968236452/job/18962635519#step:11:12851 ...

@jerboaa
Copy link
Collaborator Author

jerboaa commented Dec 4, 2023

Can we disable this test again - until we can reliably enable it again - as it's causing a lot of noise?

zakkak added a commit to zakkak/mandrel that referenced this issue Dec 5, 2023
This reverts commit ca15aab since it's
causing CI failures. We need to investigate more and re-enable once the
tests are more reliable.

Relates to Karm/mandrel-integration-tests#226
zakkak added a commit to graalvm/mandrel that referenced this issue Dec 5, 2023
This reverts commit ca15aab since it's
causing CI failures. We need to investigate more and re-enable once the
tests are more reliable.

Relates to Karm/mandrel-integration-tests#226
@zakkak
Copy link
Collaborator

zakkak commented Dec 5, 2023

Can we disable this test again - until we can reliably enable it again - as it's causing a lot of noise?

Done in graalvm/mandrel#626

@jerboaa
Copy link
Collaborator Author

jerboaa commented Dec 5, 2023

Thanks!

@zakkak
Copy link
Collaborator

zakkak commented Dec 7, 2023

Interestingly, the only time it passed was in https://github.com/zakkak/mandrel/actions/runs/6944009708/job/18891435883 (while testing before merging the PR that enabled these tests)

Turns out that's not true.

The test was passing in https://github.com/graalvm/mandrel/actions/runs/6999473951/job/19039243355#step:11:13026

So the first known bad commit seems to be 61edae46e0287ecaee7f5b3ef728ab4a6d465c02 in https://github.com/graalvm/mandrel/actions/runs/7026828114/job/19120880487

The last known working commit seems to be 670b43cac8587d27d7810af41c22ca3cf161df23 in https://github.com/graalvm/mandrel/actions/runs/7012992753/job/19078995046

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants