Ehancements to constructor call tokenizations #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add cases for 1) instantiation with no brackets 2) instantiation with a variable name instead of class name - Added test cases for new static/parent/self
|
Tests are passing, and looks like this is a good change, give me some time for testing edge cases. Thanks for PR! |
|
Happy to have it reviewed. I've been using this modification for quite a while now (php 8.2) and haven't noticed any problems. |
|
@KapitanOczywisty can we progress here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Alternate Designs
Possible Drawbacks
Applicable Issues
#7