Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Canvas): Show endpoint name in direct #1617

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

lordrip
Copy link
Member

@lordrip lordrip commented Nov 12, 2024

Context

This commit shows the endpoint name as the direct label in the canvas.

Before After
image image

Camel Route

- route:
    id: route-1365
    from:
      id: from-4377
      uri: direct
      parameters:
        name: anotherWorld
      steps:
        - to:
            id: to-1313
            uri: direct
            parameters:
              name: thisWorld
        - poll:
            id: poll-3430
            uri: direct
            parameters:
              name: thatWorld

fix: #814

This commit shows the endpoint name as the `direct` label in the canvas.

fix: KaotoIO#814
Copy link

sonarcloud bot commented Nov 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
26.1% Duplication on New Code (required ≤ 20%)

See analysis details on SonarQube Cloud

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@9be2b96). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1617   +/-   ##
=======================================
  Coverage        ?   80.01%           
  Complexity      ?      273           
=======================================
  Files           ?      280           
  Lines           ?     8015           
  Branches        ?     1537           
=======================================
  Hits            ?     6413           
  Misses          ?     1542           
  Partials        ?       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lordrip lordrip marked this pull request as ready for review November 15, 2024 08:51
@lordrip lordrip merged commit 166353d into KaotoIO:main Nov 15, 2024
12 of 13 checks passed
@lordrip lordrip deleted the feat/show-direct-as-label branch November 15, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide route name in direct node's label
1 participant