Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Entities): Connect from with route object #1579

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

lordrip
Copy link
Member

@lordrip lordrip commented Oct 16, 2024

Context

Currently, the from object is disconnected from the route object, and in order to make the VisualizationNodes IDs static, we need to connect the entire tree.

@lordrip lordrip requested a review from tplevko October 16, 2024 11:40
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 72.63158% with 26 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@a8a532d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...odels/visualization/flows/kamelet-visual-entity.ts 65.21% 8 Missing ⚠️
...s/visualization/flows/camel-route-visual-entity.ts 75.00% 5 Missing ⚠️
...isualization/flows/abstract-camel-visual-entity.ts 78.57% 3 Missing ⚠️
...zation/flows/camel-intercept-from-visual-entity.ts 0.00% 2 Missing ⚠️
.../camel-intercept-send-to-endpoint-visual-entity.ts 0.00% 2 Missing ⚠️
...sualization/flows/camel-intercept-visual-entity.ts 0.00% 2 Missing ⚠️
...ization/flows/camel-on-completion-visual-entity.ts 0.00% 2 Missing ⚠️
...lization/flows/camel-on-exception-visual-entity.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1579   +/-   ##
=======================================
  Coverage        ?   79.97%           
  Complexity      ?      272           
=======================================
  Files           ?      278           
  Lines           ?     7917           
  Branches        ?     1508           
=======================================
  Hits            ?     6332           
  Misses          ?     1524           
  Partials        ?       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lordrip lordrip force-pushed the fix/connect-route-definition branch from 00142c8 to bd5ac88 Compare October 16, 2024 12:30
Currently, the `from` object is disconnected from the `route` object,
and in order to make the `VisualizationNodes` IDs static, we need to
connect the entire tree.
@lordrip lordrip force-pushed the fix/connect-route-definition branch from bd5ac88 to 5408c24 Compare October 16, 2024 14:30
Copy link

sonarcloud bot commented Oct 16, 2024

Copy link
Member

@apupier apupier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not found specific issue to this branch but I'm not sure which parts might be potentially affected with current code change

@lordrip lordrip merged commit 2e6d8e6 into KaotoIO:main Oct 17, 2024
11 of 12 checks passed
@lordrip lordrip deleted the fix/connect-route-definition branch October 17, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants