fix(MultiplyingArchitecture): Avoid setting stale edits #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, an MA edit lifecycle looks like the following: 1. The Kaoto editor makes an edit and notifies the MA. 2. After a quiet period (debounce), MA process the edit and sends it back to the Kaoto editor. 3. If the content is the same, this last call is ignored by Kaoto, as the editor content is exactly the same, so there's no need to recreate the UI. If the contrary, the current state gets discarded and the UI is regenerated with the incoming content. This process opens the case for an edit happening a few milliseconds before the MA sending the content back, meaning that at this stage, the Kaoto content has changed but is receiving a stale content, causing for the UI to be regenerated with the stale content. The fix for this situation is to implement a hash for each content and validate whether the incoming content is stale or not. fix: KaotoIO#1376 fix: https://issues.redhat.com/projects/KTO/issues/KTO-452
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1419 +/- ##
=======================================
Coverage ? 67.52%
Complexity ? 25
=======================================
Files ? 266
Lines ? 7600
Branches ? 1520
=======================================
Hits ? 5132
Misses ? 2465
Partials ? 3 ☔ View full report in Codecov by Sentry. |
igarashitm
approved these changes
Sep 9, 2024
apupier
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, an MA edit lifecycle looks like the following:
This process opens the case for an edit happening a few milliseconds before the MA sends the content back, meaning that at this stage, the Kaoto content has changed but is receiving stale content, causing the UI to be regenerated with the stale content.
Changes
The fix for this situation is to implement a hash for each content and validate whether the incoming content is stale or not.
This PR also takes the opportunity to bring a couple of missing tests for the existing MA functionality.
fix: #1376
fix: https://issues.redhat.com/projects/KTO/issues/KTO-452