Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Canvas): Add Node mapper #1337

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

lordrip
Copy link
Member

@lordrip lordrip commented Aug 19, 2024

Context

Currently, EIPs with children are rendered as containers, as opposed to in the past, where they were rendered as nodes.

The goal for this ticket is to be able to customize how each EIP is rendered.

This is an intermediate step between having a single class holding the entire route vs having individual classes per EIP, each holding the underlying code section they represent.

fix: #1329

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 96.33028% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@bf06625). Learn more about missing BASE report.

Files Patch % Lines
...ualization/flows/nodes/mappers/base-node-mapper.ts 95.83% 2 Missing ⚠️
...lization/flows/camel-on-exception-visual-entity.ts 0.00% 1 Missing ⚠️
...n/flows/camel-route-configuration-visual-entity.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1337   +/-   ##
=======================================
  Coverage        ?   63.10%           
  Complexity      ?       25           
=======================================
  Files           ?      255           
  Lines           ?     6854           
  Branches        ?     1565           
=======================================
  Hits            ?     4325           
  Misses          ?     2523           
  Partials        ?        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Currently, EIPs with children are rendered as containers, as opposed to in the past, where they were rendered as nodes.

The goal for this ticket is to be able to customize how each EIP is rendered.

This is an intermediate step between having a single class holding the
entire route vs having individual classes per EIP, each holding the
underlying code section they represent.

fix: KaotoIO#1329
Copy link

sonarcloud bot commented Aug 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
7.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@lordrip lordrip merged commit 68a9f66 into KaotoIO:main Aug 19, 2024
11 of 12 checks passed
@lordrip lordrip deleted the feat/custom-viz branch August 19, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support custom visualization for EIPs
1 participant