Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(1075): hover on Layout buttons of catalog modal #1189

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

tplevko
Copy link
Contributor

@tplevko tplevko commented Jun 21, 2024

fixes #1075

vokoscreenNG-2024-06-21_08-10-31.mov

@tplevko tplevko marked this pull request as draft June 21, 2024 13:28
@tplevko tplevko marked this pull request as ready for review June 24, 2024 06:31
@lordrip
Copy link
Member

lordrip commented Jun 24, 2024

@tplevko, for the Canvas, we use the Tooltip component, but here we're using Popover.
image

Do you think we should use the former instead?

Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just missing a yarn lint:fix and we're good :)

@lordrip lordrip merged commit 482ea1d into KaotoIO:main Jun 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide hover on Layout buttons of catalog modal
2 participants