Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(991): Removing useMemo() from the code #1168

Merged
merged 1 commit into from
Jun 19, 2024
Merged

fix(991): Removing useMemo() from the code #1168

merged 1 commit into from
Jun 19, 2024

Conversation

shivamG640
Copy link
Contributor

@shivamG640 shivamG640 commented Jun 17, 2024 •
edited
Loading

Description

This PR is related to a previous PR, where I added the following two changes:

  1. Removed the useMemo() calls as I found out that it is unnecessarily used and the underlying code is getting executed all the time the component is re-executed as we inject an object as it dependency. I might be incorrect on this so please let me know if we need a discussion over this.
  2. Modified the id to make it unique for all the groups in the expandable section.

@shivamG640
Copy link
Contributor Author

@lordrip , Please have a look at this!

@shivamG640 shivamG640 requested a review from lordrip June 18, 2024 08:52
@lordrip lordrip marked this pull request as ready for review June 19, 2024 14:58
@lordrip lordrip merged commit 929c66a into KaotoIO:main Jun 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lordrip lordrip lordrip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shivamG640 @lordrip