Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(835) - make the config panel resizable #1158

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

tplevko
Copy link
Contributor

@tplevko tplevko commented Jun 14, 2024

@@ -186,7 +186,7 @@ export const Canvas: FunctionComponent<PropsWithChildren<CanvasProps>> = (props)
useEffect(() => {
const timeoutId = setTimeout(() => {
controller.getGraph().fit(80);
}, 250);
}, 500);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increased the graph alignment timeout, because the resizable sidebar takes a bit more time to be displayed and 250 miliseconds was not enough in most cases

@tplevko tplevko marked this pull request as ready for review June 17, 2024 11:29
@tplevko
Copy link
Contributor Author

tplevko commented Jun 17, 2024

the second point from the issue - Store the expanded size in localStorage, so the user keeps their preference is not achieved by this PR, as I there doesn't seem to be an easy way to store the new size to localStorage.

@lordrip lordrip merged commit 9762efd into KaotoIO:main Jun 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resizable Config Panel
2 participants