Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(catalog): Fix for Log component selection in catalog list view #1115

Merged
merged 1 commit into from
May 28, 2024

Conversation

shivamG640
Copy link
Contributor

Fixes #1089,

This issue was due to less strict comparison of the chosen list ID with tile name in packages/ui/src/components/Catalog/BaseCatalog.tsx which leads to log processor getting matched with log component. Adding a strict comparison fix the issue!

@shivamG640 shivamG640 requested a review from lordrip May 28, 2024 11:13
Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @shivamG640 👍

@shivamG640 shivamG640 merged commit 5446204 into KaotoIO:main May 28, 2024
9 checks passed
@shivamG640 shivamG640 deleted the Fix_1089 branch May 28, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In the catalog list view, only the log component can be selected
2 participants