Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expression and Dataformat Metadata editing - might omit form field #904

Closed
tplevko opened this issue Mar 5, 2024 · 2 comments · Fixed by #922
Closed

Expression and Dataformat Metadata editing - might omit form field #904

tplevko opened this issue Mar 5, 2024 · 2 comments · Fixed by #922
Assignees
@lordrip
Labels
bug Something isn't working canvas/config-form Configuration form related issues ui/ux This issue is about improving the UI / UX
Milestone
2.0.0 TP3

Comments

@tplevko
Copy link
Contributor

tplevko commented Mar 5, 2024

Describe the Bug

When the users includes config in a form field, which has same name as form field of another language/dataformat type, to which they can switch - the previously configured form field might get omited.

Steps to Reproduce the Bug or Issue

  1. open the expression or dataformat editor
  2. select a value from the dropdown
  3. fill a form value
  4. switch to second type using the dropdown
  5. see the value in the form field stayed the same
  6. save
  7. in source code - see the value from the form filed is missing

Screenshots or Videos

vokoscreenNG-2024-03-05_13-34-01.webm

Platform

  • OS: [e.g. macOS, Windows, Linux]
  • Browser: [e.g. Chrome, Safari, Firefox]
  • Version: [e.g. 0.30.0]
@tplevko tplevko added the bug Something isn't working label Mar 5, 2024
@tplevko tplevko added the canvas/config-form Configuration form related issues label Mar 5, 2024
@lordrip lordrip moved this from New to Todo in Kanban Board Mar 5, 2024
@lordrip lordrip added this to the 2.0.0 milestone Mar 5, 2024
@lordrip lordrip added the ui/ux This issue is about improving the UI / UX label Mar 5, 2024
@lordrip
Copy link
Member

lordrip commented Mar 5, 2024

Since potentially the expression could be a different syntax, one thing to consider is whether we want to preserve the ID and the expression field.

lordrip added a commit to lordrip/kaoto that referenced this issue Mar 8, 2024
@lordrip
fix(CanvasForm): Expression form hold stale data
79dbbd9 
When the users includes config in a form field, which has same name as form field of another
language/dataformat type, to which they can switch - the previously configured form field might get omited.

The fix is to assign a key to the form, so React know that the form
should be recreated without reusing the existing fields.

fix: KaotoIO#904
@lordrip lordrip mentioned this issue Mar 8, 2024
Merged
@lordrip lordrip self-assigned this Mar 8, 2024
@lordrip lordrip moved this from Todo to In Review in Kanban Board Mar 8, 2024
lordrip added a commit to lordrip/kaoto that referenced this issue Mar 11, 2024
@lordrip
fix(CanvasForm): Expression form hold stale data
d64fba6 
When the users includes config in a form field, which has same name as form field of another
language/dataformat type, to which they can switch - the previously configured form field might get omited.

The fix is to assign a key to the form, so React know that the form
should be recreated without reusing the existing fields.

fix: KaotoIO#904
@lordrip
Copy link
Member

lordrip commented Mar 11, 2024

As pointed out by @tplevko, apart from the ExpressionEditor, the DataFormat and the Language editors are also affected.

lordrip added a commit that referenced this issue Mar 12, 2024
@lordrip
fix(CanvasForm): Expression form hold stale data
0d1b688 
When the users includes config in a form field, which has same name as form field of another
language/dataformat type, to which they can switch - the previously configured form field might get omited.

The fix is to assign a key to the form, so React know that the form
should be recreated without reusing the existing fields.

fix: #904
@github-project-automation github-project-automation bot moved this from In Review to Done in Kanban Board Mar 12, 2024
tplevko pushed a commit to tplevko/kaoto-next that referenced this issue Mar 12, 2024
@lordrip @tplevko
fix(CanvasForm): Expression form hold stale data
dc335fc 
When the users includes config in a form field, which has same name as form field of another
language/dataformat type, to which they can switch - the previously configured form field might get omited.

The fix is to assign a key to the form, so React know that the form
should be recreated without reusing the existing fields.

fix: KaotoIO#904
tplevko pushed a commit to tplevko/kaoto-next that referenced this issue Mar 12, 2024
@lordrip @tplevko
fix(CanvasForm): Expression form hold stale data
adf1bd6 
When the users includes config in a form field, which has same name as form field of another
language/dataformat type, to which they can switch - the previously configured form field might get omited.

The fix is to assign a key to the form, so React know that the form
should be recreated without reusing the existing fields.

fix: KaotoIO#904
@tplevko tplevko mentioned this issue Jun 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lordrip lordrip

Labels
bug Something isn't working canvas/config-form Configuration form related issues ui/ux This issue is about improving the UI / UX
Projects
Kanban Board
Archived in project
Milestone
2.0.0 TP3
Development

Successfully merging a pull request may close this issue.

fix(CanvasForm): Expression form hold stale data lordrip/kaoto
2 participants
@tplevko @lordrip