Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid serializing empty strings #1022

Closed
lordrip opened this issue Apr 18, 2024 · 3 comments · Fixed by #1028, #1198 or #1203
Closed

Avoid serializing empty strings #1022

lordrip opened this issue Apr 18, 2024 · 3 comments · Fixed by #1028, #1198 or #1203
Assignees
@shivamG640
Labels
bug Something isn't working canvas/config-form Configuration form related issues good first issue Good for newcomers help wanted Extra attention is needed source code editor Source Code Editor-related issues
Milestone
2.1.0

Comments

@lordrip
Copy link
Member

lordrip commented Apr 18, 2024

Describe the Bug

In case a string field is touched and later on clean, the resulting YAML looks like the following:

property: ""

This is an issue for the expression field in which the resultType property gets an empty string and it makes the route to fail.

              - expression:
                  simple:
                    expression: ${body[0]}
                    resultType: ""

Steps to Reproduce the Bug or Issue

  1. Using a setHeader EIP, edit the resultType property
  2. Clean the field
  3. Check how the resultType property is now an empty string

Screenshots or Videos

No response

Platform

  • OS: [e.g. macOS, Windows, Linux]
  • Browser: [e.g. Chrome, Safari, Firefox]
  • Version: [e.g. 0.30.0]
@lordrip lordrip added the bug Something isn't working label Apr 18, 2024
@lordrip lordrip added good first issue Good for newcomers help wanted Extra attention is needed source code editor Source Code Editor-related issues canvas/config-form Configuration form related issues labels Apr 18, 2024
@lhein lhein moved this from New to Todo in Kanban Board Apr 23, 2024
@lhein lhein added this to the 2.0.0 milestone Apr 23, 2024
@lordrip lordrip moved this from Todo to In Progress in Kanban Board Apr 23, 2024
@lordrip lordrip self-assigned this Apr 23, 2024
lordrip added a commit to lordrip/kaoto that referenced this issue Apr 23, 2024
@lordrip
fix(CanvasForm): Avoid serializing empty strings
cb98579 
Currently, when a string field is touched and later on clean, the resulting YAML looks like the following:
```
property: ''
```

And this represents an issue since many properties can't be left blank.

This commit avoids serializing empty `''` strings by replace them with
`undefined` instead.

fix: KaotoIO#1022
@lordrip lordrip mentioned this issue Apr 23, 2024
Merged
@lordrip lordrip moved this from In Progress to In Review in Kanban Board Apr 23, 2024
lordrip added a commit that referenced this issue Apr 23, 2024
@lordrip
fix(CanvasForm): Avoid serializing empty strings
3c7591e 
Currently, when a string field is touched and later on clean, the resulting YAML looks like the following:
```
property: ''
```

And this represents an issue since many properties can't be left blank.

This commit avoids serializing empty `''` strings by replace them with
`undefined` instead.

fix: #1022
@github-project-automation github-project-automation bot moved this from In Review to Done in Kanban Board Apr 23, 2024
@tplevko tplevko mentioned this issue Jun 14, 2024
Merged
@lordrip
Copy link
Member Author

lordrip commented Jun 14, 2024

This looks like is happening again, reopening.

@lordrip lordrip reopened this Jun 14, 2024
@github-project-automation github-project-automation bot moved this from Done to Todo in Kanban Board Jun 14, 2024
@lordrip lordrip modified the milestones: 2.0.0, 2.1.0 Jun 14, 2024
@lordrip lordrip removed their assignment Jun 14, 2024
@lordrip lordrip moved this from Todo to In Progress in Kanban Board Jun 24, 2024
@shivamG640 shivamG640 mentioned this issue Jun 24, 2024
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Kanban Board Jun 25, 2024
@tplevko
Copy link
Contributor

tplevko commented Jun 25, 2024

It's still occurring in case the fields are a part of an expression:

Screenshot from 2024-06-25 12-30-51

Should I reopen this issue or create new one for expressions only?

@lordrip
Copy link
Member Author

lordrip commented Jun 25, 2024

Reopening issue as there another case to take into account

@lordrip lordrip reopened this Jun 25, 2024
@github-project-automation github-project-automation bot moved this from Done to Todo in Kanban Board Jun 25, 2024
@shivamG640 shivamG640 moved this from Todo to In Progress in Kanban Board Jun 25, 2024
@shivamG640 shivamG640 mentioned this issue Jun 25, 2024
Merged
@shivamG640 shivamG640 moved this from In Progress to In Review in Kanban Board Jun 26, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Kanban Board Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shivamG640 shivamG640

Labels
bug Something isn't working canvas/config-form Configuration form related issues good first issue Good for newcomers help wanted Extra attention is needed source code editor Source Code Editor-related issues
Projects
Kanban Board
Archived in project
Milestone
2.1.0
4 participants
@lhein @tplevko @lordrip @shivamG640