Use correct character variants in certain kvg:element attributes #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some files used a similar-looking character in the kvg:element attribute which did not match the codepoint they are supposed to represent. In particular, replace 令 with 令 in several places.
|
Thank you for this correction. I've now applied it. You might want to use a different branch each time you make a correction since adding this to the "master" branch in your repo meant it ended up being stuck on to the previous commit. Thanks again for the correction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some files, the character used in the
kvg:elementattribute does not match the codepoint which the file is supposed to represent, which could cause trouble for search tools. Most of these stem from 令 being used in place of 令 (which is one of the "CJK Compatibility Ideographs").Additionally, I noticed that the
idattributes in0f9ad.svguse the code0f9abinstead. This has been fixed to avoid conflicts with theids in0f9ab.svg.